Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2073393002: add some missing power_save_blocker gyp deps (Closed)

Created:
4 years, 6 months ago by Mostyn Bramley-Moore
Modified:
4 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add some missing power_save_blocker gyp deps Followup to https://codereview.chromium.org/2075153002 BUG=612337, 612563, 257943 Committed: https://crrev.com/d031a4bc2c65557c7ade9268f4cbb538e15d7e58 Cr-Commit-Position: refs/heads/master@{#400723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M device/power_save_blocker/power_save_blocker.gyp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073393002/1
4 years, 6 months ago (2016-06-18 23:34:22 UTC) #2
Mostyn Bramley-Moore
@jam, scottmg: please take a look at this followup to the power_save_blocker move.
4 years, 6 months ago (2016-06-18 23:45:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-19 00:14:11 UTC) #6
scottmg
Thanks, sorry, I don't think there's any gyp linux bots any more. lgtm
4 years, 6 months ago (2016-06-20 03:25:16 UTC) #7
jam
(removing myself as scott is owner)
4 years, 6 months ago (2016-06-20 15:51:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073393002/1
4 years, 6 months ago (2016-06-20 17:29:25 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-20 18:05:56 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 18:10:48 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d031a4bc2c65557c7ade9268f4cbb538e15d7e58
Cr-Commit-Position: refs/heads/master@{#400723}

Powered by Google App Engine
This is Rietveld 408576698