Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2075153002: Reland of 'Move content/browser/power_save_blocker to //device/power_save_blocker' (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asanka, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, dcheng, rginda+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, sdefresne+watchlist_chromium.org, jam, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, avayvod+watch_chromium.org, pfeldman, isheriff+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of 'Move content/browser/power_save_blocker to //device/power_save_blocker' Original at https://codereview.chromium.org/1999953002. Changes are ps#1 to ps#2 (fix for Mac build files). R=jam@chromium.org TBR=rockot BUG=612337, 612563, 257943 Committed: https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9 Cr-Commit-Position: refs/heads/master@{#400451}

Patch Set 1 #

Patch Set 2 : missing libs for component mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -1541 lines) Patch
M chrome/browser/media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M components/drive/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/drive/DEPS View 3 chunks +4 lines, -9 lines 0 comments Download
M components/drive/drive_uploader.cc View 3 chunks +11 lines, -6 lines 0 comments Download
M content/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/app/android/library_loader_hooks.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 2 chunks +1 line, -13 lines 0 comments Download
M content/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 6 chunks +23 lines, -21 lines 0 comments Download
M content/browser/download/download_request_core.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/download/download_request_core.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 2 chunks +4 lines, -3 lines 0 comments Download
D content/browser/power_save_blocker_android.h View 1 chunk +0 lines, -11 lines 0 comments Download
D content/browser/power_save_blocker_android.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D content/browser/power_save_blocker_chromeos.cc View 1 chunk +0 lines, -112 lines 0 comments Download
A + content/browser/power_save_blocker_factory.h View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/power_save_blocker_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download
D content/browser/power_save_blocker_impl.h View 1 chunk +0 lines, -74 lines 0 comments Download
D content/browser/power_save_blocker_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D content/browser/power_save_blocker_mac.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D content/browser/power_save_blocker_ozone.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/browser/power_save_blocker_win.cc View 1 chunk +0 lines, -160 lines 0 comments Download
D content/browser/power_save_blocker_x11.cc View 1 chunk +0 lines, -508 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +7 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 7 chunks +3 lines, -14 lines 0 comments Download
M content/content_jni.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/PowerSaveBlocker.java View 1 chunk +0 lines, -46 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
D content/public/browser/power_save_blocker.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/public/browser/power_save_blocker_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
M device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A device/power_save_blocker/BUILD.gn View 1 1 chunk +96 lines, -0 lines 0 comments Download
A device/power_save_blocker/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A device/power_save_blocker/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A + device/power_save_blocker/android/java/src/org/chromium/device/power_save_blocker/PowerSaveBlocker.java View 2 chunks +2 lines, -2 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker.h View 3 chunks +7 lines, -7 lines 0 comments Download
A device/power_save_blocker/power_save_blocker.gyp View 1 1 chunk +54 lines, -0 lines 0 comments Download
A device/power_save_blocker/power_save_blocker_android.h View 1 chunk +16 lines, -0 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_android.cc View 3 chunks +4 lines, -5 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_chromeos.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A device/power_save_blocker/power_save_blocker_export.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_impl.h View 4 chunks +8 lines, -7 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A device/power_save_blocker/power_save_blocker_jni_registrar.h View 1 chunk +24 lines, -0 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_jni_registrar.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_mac.cc View 6 chunks +12 lines, -13 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_ozone.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_win.cc View 3 chunks +4 lines, -5 lines 0 comments Download
A + device/power_save_blocker/power_save_blocker_x11.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M device/test/run_all_unittests.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/power/power_api.h View 3 chunks +8 lines, -6 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 5 chunks +21 lines, -14 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
scottmg
WebKit Mac Builder is gn debug component, but we don't have one of those on ...
4 years, 6 months ago (2016-06-17 16:01:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2075153002/20001
4 years, 6 months ago (2016-06-17 17:09:27 UTC) #7
jam
lgtm
4 years, 6 months ago (2016-06-17 17:47:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 17:58:07 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 17:59:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c40e88210fdf15e85a553573584d217d6f8273b9
Cr-Commit-Position: refs/heads/master@{#400451}

Powered by Google App Engine
This is Rietveld 408576698