Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2073353002: Merge PowerSaveBlockerImpl and PowerSaveBlocker (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, extensions-reviews_chromium.org, jam, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, darin-cc_chromium.org, mmenke, mcasas+watch+vc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, pfeldman, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-power-factory
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge PowerSaveBlockerImpl and PowerSaveBlocker Followup to https://codereview.chromium.org/1999953002. The split was previously required to expose via the content API, but now we can collapse them after moving to //device. BUG=612337, 612563 Committed: https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969 Cr-Commit-Position: refs/heads/master@{#400567}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -260 lines) Patch
M chrome/browser/media/cast_transport_host_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/drive/drive_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -20 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M content/browser/download/download_request_core.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/power_save_block_resource_throttle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M device/power_save_blocker/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/power_save_blocker/power_save_blocker.h View 1 2 chunks +43 lines, -4 lines 0 comments Download
M device/power_save_blocker/power_save_blocker.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_android.cc View 7 chunks +11 lines, -10 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_chromeos.cc View 4 chunks +5 lines, -5 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_impl.h View 1 chunk +0 lines, -75 lines 0 comments Download
D device/power_save_blocker/power_save_blocker_impl.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_mac.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_ozone.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_win.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M device/power_save_blocker/power_save_blocker_x11.cc View 1 16 chunks +21 lines, -22 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 1 3 chunks +13 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
jam
lgtm
4 years, 6 months ago (2016-06-17 22:31:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073353002/40001
4 years, 6 months ago (2016-06-18 00:35:19 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-18 01:33:29 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-18 01:34:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/05236db107f7843dcbff08718f2ef2bd2c248969
Cr-Commit-Position: refs/heads/master@{#400567}

Powered by Google App Engine
This is Rietveld 408576698