Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2072403002: Remove content/browser/power_save_blocker_factory.* (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, jam, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, darin-cc_chromium.org, mmenke, mcasas+watch+vc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, pfeldman, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content/browser/power_save_blocker_factory.* Followup to https://codereview.chromium.org/1999953002. Just inline the creation call rather than having a separate factory function. R=jam@chromium.org BUG=612337, 612563 Committed: https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea Cr-Commit-Position: refs/heads/master@{#400534}

Patch Set 1 #

Patch Set 2 : component #

Total comments: 1

Patch Set 3 : gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -83 lines) Patch
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 4 chunks +13 lines, -7 lines 0 comments Download
M content/browser/download/download_request_core.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/aura_window_capture_machine.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/media/media_web_contents_observer.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/media/webrtc/webrtc_internals.cc View 2 chunks +5 lines, -3 lines 0 comments Download
D content/browser/power_save_blocker_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/browser/power_save_blocker_factory.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/wake_lock/wake_lock_service_context.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (2 generated)
scottmg
4 years, 6 months ago (2016-06-17 20:22:27 UTC) #1
jam
https://codereview.chromium.org/2072403002/diff/20001/content/browser/wake_lock/wake_lock_service_context.cc File content/browser/wake_lock/wake_lock_service_context.cc (right): https://codereview.chromium.org/2072403002/diff/20001/content/browser/wake_lock/wake_lock_service_context.cc#newcode71 content/browser/wake_lock/wake_lock_service_context.cc:71: wake_lock_ = device::PowerSaveBlocker::CreateWithTaskRunners( can we also get rid of ...
4 years, 6 months ago (2016-06-17 22:11:58 UTC) #2
scottmg
On 2016/06/17 22:11:58, jam wrote: > https://codereview.chromium.org/2072403002/diff/20001/content/browser/wake_lock/wake_lock_service_context.cc > File content/browser/wake_lock/wake_lock_service_context.cc (right): > > https://codereview.chromium.org/2072403002/diff/20001/content/browser/wake_lock/wake_lock_service_context.cc#newcode71 > ...
4 years, 6 months ago (2016-06-17 22:17:27 UTC) #3
scottmg
On 2016/06/17 22:17:27, scottmg wrote: > On 2016/06/17 22:11:58, jam wrote: > > > https://codereview.chromium.org/2072403002/diff/20001/content/browser/wake_lock/wake_lock_service_context.cc ...
4 years, 6 months ago (2016-06-17 22:28:33 UTC) #4
jam
lgtm
4 years, 6 months ago (2016-06-17 22:29:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072403002/40001
4 years, 6 months ago (2016-06-17 22:32:23 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-17 23:08:13 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 23:09:46 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/90f7c1198c9c1ceb406834061b31f8f980b672ea
Cr-Commit-Position: refs/heads/master@{#400534}

Powered by Google App Engine
This is Rietveld 408576698