Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2073343003: [Presubmit] check styles with include parameters (Closed)

Created:
4 years, 6 months ago by dschuyler
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam, dpapad
CC:
chromium-reviews, tsergeant
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presubmit] check styles with include parameters This CL causes the css checker to be run on style tags such as <style include="foo"> that were previously ignored by presubmit. BUG=621267 Committed: https://crrev.com/fd8bd32b61e0698ac4d478699e76096a2397fa80 Cr-Commit-Position: refs/heads/master@{#400782}

Patch Set 1 #

Patch Set 2 : adding test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/web_dev_style/css_checker.py View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/web_dev_style/css_checker_test.py View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
dschuyler
4 years, 6 months ago (2016-06-18 01:06:14 UTC) #2
dpapad
lgtm
4 years, 6 months ago (2016-06-18 01:06:44 UTC) #3
dschuyler
4 years, 6 months ago (2016-06-18 01:10:56 UTC) #5
Dan Beam
lgtm
4 years, 6 months ago (2016-06-18 01:37:55 UTC) #6
Dan Beam
can you write a test or update the current ones to have an include="" though?
4 years, 6 months ago (2016-06-18 01:38:16 UTC) #7
dschuyler
Added a test.
4 years, 6 months ago (2016-06-20 19:02:41 UTC) #8
Dan Beam
lgtm \o/
4 years, 6 months ago (2016-06-20 19:12:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073343003/20001
4 years, 6 months ago (2016-06-20 21:13:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 21:19:27 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 21:21:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd8bd32b61e0698ac4d478699e76096a2397fa80
Cr-Commit-Position: refs/heads/master@{#400782}

Powered by Google App Engine
This is Rietveld 408576698