Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4638)

Unified Diff: chrome/browser/web_dev_style/css_checker.py

Issue 2073343003: [Presubmit] check styles with include parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/css_checker_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_dev_style/css_checker.py
diff --git a/chrome/browser/web_dev_style/css_checker.py b/chrome/browser/web_dev_style/css_checker.py
index 22ce63e73c8349eb3e14a9d780a165df53b4f7e9..930e6aa592ddfcaec7d124c7d809d1fd64f2f851 100644
--- a/chrome/browser/web_dev_style/css_checker.py
+++ b/chrome/browser/web_dev_style/css_checker.py
@@ -37,7 +37,7 @@ class CSSChecker(object):
return s
def _extract_inline_style(s):
- return '\n'.join(re.findall(r'<style>([^<]*)<\/style>', s))
+ return '\n'.join(re.findall(r'<style\b[^>]*>([^<]*)<\/style>', s))
def _remove_ats(s):
at_reg = re.compile(r"""
@@ -394,7 +394,7 @@ class CSSChecker(object):
for f in files:
file_errors = []
for check in added_or_modified_files_checks:
- # If the check is multiline, it receieves the whole file and gives us
+ # If the check is multiline, it receives the whole file and gives us
# back a list of things wrong. If the check isn't multiline, we pass it
# each line and the check returns something truthy if there's an issue.
if ('multiline' in check and check['multiline']):
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/css_checker_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698