Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 207323002: Gamepad API: add test support for gamepad events (Closed)

Created:
6 years, 9 months ago by kbalazs
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Gamepad API: add test support for gamepad events This CL adds layout test support for 'gamepadconnected' and 'gamepaddidconnected' events. BUG=344556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259102

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -3 lines) Patch
M content/public/test/layouttest_support.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +11 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 4 chunks +23 lines, -0 lines 1 comment Download
M content/shell/renderer/test_runner/WebTestDelegate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.h View 1 chunk +8 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 4 chunks +20 lines, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kbalazs
Depends on https://codereview.chromium.org/200783002/ which is close to land.
6 years, 9 months ago (2014-03-20 23:46:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/207323002/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (right): https://codereview.chromium.org/207323002/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#newcode140 content/renderer/renderer_webkitplatformsupport_impl.cc:140: static blink::WebGamepadListener* web_gamepad_listener = NULL; can this be ...
6 years, 9 months ago (2014-03-24 12:22:39 UTC) #2
kbalazs
On 2014/03/24 12:22:39, jochen wrote: > lgtm > > https://codereview.chromium.org/207323002/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc > File content/renderer/renderer_webkitplatformsupport_impl.cc (right): > ...
6 years, 9 months ago (2014-03-24 20:03:29 UTC) #3
kbalazs
The CQ bit was checked by b.kelemen@samsung.com
6 years, 9 months ago (2014-03-24 21:29:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@samsung.com/207323002/1
6 years, 9 months ago (2014-03-24 21:31:33 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 02:20:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 259102

Powered by Google App Engine
This is Rietveld 408576698