Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2073123002: [builtins] Introduce proper Float64Cos and Float64Sin. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper Float64Cos and Float64Sin. Import base::ieee754::cos() and base::ieee754::sin() from fdlibm and introduce Float64Cos and Float64Sin TurboFan operator based on that, similar to what we do for Float64Log. Rewrite Math.cos() and Math.sin() as TurboFan builtins and use those operators to also inline Math.cos() and Math.sin() into optimized TurboFan functions. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel R=mvstanton@chromium.org BUG=v8:5086, v8:5118 Committed: https://crrev.com/c781e83194031b337f8eafb42588a2e3d7440782 Cr-Commit-Position: refs/heads/master@{#37072}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix missing breaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1484 lines, -238 lines) Patch
M src/assembler.h View 1 chunk +6 lines, -7 lines 0 comments Download
M src/assembler.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/base/ieee754.h View 2 chunks +9 lines, -3 lines 0 comments Download
M src/base/ieee754.cc View 3 chunks +713 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/builtins.h View 4 chunks +6 lines, -0 lines 0 comments Download
M src/builtins.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/code-assembler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector.cc View 4 chunks +18 lines, -6 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 7 chunks +53 lines, -23 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +14 lines, -8 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/representation-change.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 3 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 2 chunks +16 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 4 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 3 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 3 chunks +22 lines, -0 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 5 chunks +21 lines, -0 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 3 chunks +18 lines, -0 lines 0 comments Download
M src/external-reference-table.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 3 chunks +0 lines, -143 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 3 chunks +76 lines, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-17 13:38:06 UTC) #1
mvstanton
lgtm https://codereview.chromium.org/2073123002/diff/1/src/compiler/machine-operator-reducer.cc File src/compiler/machine-operator-reducer.cc (right): https://codereview.chromium.org/2073123002/diff/1/src/compiler/machine-operator-reducer.cc#newcode402 src/compiler/machine-operator-reducer.cc:402: } Missing break
4 years, 6 months ago (2016-06-17 13:51:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073123002/20001
4 years, 6 months ago (2016-06-17 13:56:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073123002/20001
4 years, 6 months ago (2016-06-17 13:57:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 15:22:02 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 15:24:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c781e83194031b337f8eafb42588a2e3d7440782
Cr-Commit-Position: refs/heads/master@{#37072}

Powered by Google App Engine
This is Rietveld 408576698