Issue 207303002: Handle 0 in BigintOperations::ToDecimalCString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 207303002: Handle 0 in BigintOperations::ToDecimalCString. (Closed)

Created:
6 years, 9 months ago by koda

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	runtime/vm/bigint_operations.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
	M	runtime/vm/bigint_operations_test.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

koda

Hold on, it doesn't actually produce the correct result for 0, regardless of the ASSERT. ...

6 years, 9 months ago (2014-03-20 23:46:11 UTC) #2

koda

6 years, 9 months ago (2014-03-21 15:02:30 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r34251 (presubmit successful).