Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2072873002: Fix for issue 26555, do not inherit package root and package config from the parent isolate when do… (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 26555, do not inherit package root and package config from the parent isolate when doing Isolate.spawn BUG=26555 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/da1a5534b4578511c58b6b367caca6abab5854de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -22 lines) Patch
M runtime/lib/isolate_patch.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/standalone/packages_file_test.dart View 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
4 years, 6 months ago (2016-06-16 20:40:17 UTC) #2
Cutch
lgtm
4 years, 6 months ago (2016-06-16 21:29:06 UTC) #3
siva
4 years, 6 months ago (2016-06-17 16:59:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da1a5534b4578511c58b6b367caca6abab5854de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698