Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: tests/standalone/packages_file_test.dart

Issue 2072873002: Fix for issue 26555, do not inherit package root and package config from the parent isolate when do… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/packages_file_test.dart
diff --git a/tests/standalone/packages_file_test.dart b/tests/standalone/packages_file_test.dart
index 9902d69f6a757faadb461ff8d809ccb9dd723b57..d41e46b31e885a5203d7bfb41235f62ee5308bbe 100644
--- a/tests/standalone/packages_file_test.dart
+++ b/tests/standalone/packages_file_test.dart
@@ -85,26 +85,11 @@ main() async {
/// This should not change the expected results compared to running it
/// directly.
Configuration spawn(Configuration conf) {
- // TODO(26555): Clean up when fixed.
- // TEMPORARY FIX FOR ISSUE #26555 (http://dartbug.com/26555)
- if (conf.expect["iroot"] == null &&
- conf.expect["iconf"] == null &&
- conf.expect["pconf"] != null) {
- // The spawned isolate will do a search for a package file or root,
- // which is not what the original did. Skip test for now.
- return null;
- }
- // REMOVE WHEN ISSUE FIXED!
return conf.update(
description: conf.description + "/spawn",
main: "spawnMain",
newArgs: [conf.mainType],
- // TEMPORARY FIX FOR ISSUE #26555 (http://dartbug.com/26555)
- expect: {
- "proot": conf.expect["iroot"],
- "pconf": conf.expect["iconf"],
- }
- // REMOVE WHEN ISSUE FIXED!
+ expect: null
);
}
« no previous file with comments | « runtime/lib/isolate_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698