S390: Enable unaligned accesses and character preloading in regexp.

S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/4ffe9777a0ac5e7fb54b873cf6cab1711987e533
Cr-Commit-Position: refs/heads/master@{#38306}

[Sampson, 2016-06-16 20:21:48]

Description was changed from

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

[Sampson, 2016-06-16 20:21:49]

sampsong@ca.ibm.com changed reviewers:
+ dstence@us.ibm.com, mstarzinger@chromium.org

[Sampson, 2016-06-16 20:28:13]

PTAL

[john.yan, 2016-06-16 20:55:25]

https://codereview.chromium.org/2072863003/diff/1/src/regexp/s390/regexp-macr...
File src/regexp/s390/regexp-macro-assembler-s390.cc (right):

https://codereview.chromium.org/2072863003/diff/1/src/regexp/s390/regexp-macr...
src/regexp/s390/regexp-macro-assembler-s390.cc:1237: // using load reverse for
endian issue
These reversed loads are needed to be guard with ENDIAN macros.

[JoranSiu, 2016-06-16 21:05:16]

https://codereview.chromium.org/2072863003/diff/1/src/s390/macro-assembler-s3...
File src/s390/macro-assembler-s390.cc (right):

https://codereview.chromium.org/2072863003/diff/1/src/s390/macro-assembler-s3...
src/s390/macro-assembler-s390.cc:5114: void
MacroAssembler::LoadReversedWordP(Register dst, const MemOperand& mem) {
Should these be better named as LoadLogicalReversedWordP?  (if we end up doing a
zero-extension).

[Michael Starzinger, 2016-06-17 08:19:21]

LGTM on the change to InterpreterAssembler. Didn't look at the rest at all.

[Sampson, 2016-07-19 18:36:23]

The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 18:36:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 18:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 18:36:31]

Dry run: The author sampsong@ca.ibm.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[Sampson, 2016-07-19 20:44:52]

The CQ bit was checked by sampsong@ca.ibm.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 20:45:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 21:17:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 21:17:42]

Dry run: This issue passed the CQ dry run.

[JoranSiu, 2016-07-19 21:32:17]

On 2016/06/17 08:19:21, Michael Starzinger wrote:
> LGTM on the change to InterpreterAssembler. Didn't look at the rest at all.

lgtm

[john.yan, 2016-08-02 03:06:15]

lgtm with nits

https://codereview.chromium.org/2072863003/diff/40001/src/regexp/s390/regexp-...
File src/regexp/s390/regexp-macro-assembler-s390.cc (right):

https://codereview.chromium.org/2072863003/diff/40001/src/regexp/s390/regexp-...
src/regexp/s390/regexp-macro-assembler-s390.cc:1237: // using load reverse for
endian issue
There is no 'issue' here when using reversed load. An appropriate comment would
be "using load reverse for big-endian platform"

https://codereview.chromium.org/2072863003/diff/40001/src/regexp/s390/regexp-...
src/regexp/s390/regexp-macro-assembler-s390.cc:1271: // need to swap the order
of the characters for endian issue
same here.

[Sampson, 2016-08-03 14:42:50]

The CQ bit was checked by sampsong@ca.ibm.com

[Sampson, 2016-08-03 14:42:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com
Link to the patchset: https://codereview.chromium.org/2072863003/#ps80001
(title: "Change comment on load reverse")

[commit-bot: I haz the power, 2016-08-03 14:43:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 15:14:24]

Description was changed from

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

[commit-bot: I haz the power, 2016-08-03 15:14:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-03 15:17:58]

Description was changed from

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=
==========

to

==========
S390: Enable unaligned accesses and character preloading in regexp.

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com,
mbrandy@us.ibm.com, bjaideep@ca.ibm.com
BUG=

Committed: https://crrev.com/4ffe9777a0ac5e7fb54b873cf6cab1711987e533
Cr-Commit-Position: refs/heads/master@{#38306}
==========

[commit-bot: I haz the power, 2016-08-03 15:17:59]

Patchset 5 (id:??) landed as
https://crrev.com/4ffe9777a0ac5e7fb54b873cf6cab1711987e533
Cr-Commit-Position: refs/heads/master@{#38306}