Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2072813002: Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (Closed)

Created:
4 years, 6 months ago by Brian Osman
Modified:
4 years, 6 months ago
Reviewers:
herb_g, msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType (patchset #10 id:180001 of https://codereview.chromium.org/2069173002/ ) Reason for revert: Mac crashes in GrUploadPixmapToTexture Original issue's description: > Lots of progress on switching to SkColorSpace rather than SkColorProfileType > > Fixed a bunch of code in Ganesh, as well as usage of SkColorProfileType in most of our tools (DM, SampleApp, Viewer, nanobench, skiaserve, HelloWorld). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2069173002 > > Committed: https://skia.googlesource.com/skia/+/6a61a875467646f8dbc37cfecf49e12d1f475170 TBR=reed@google.com,herb@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab8241880d09eb1774b4993ca6df048a27b7020c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -137 lines) Patch
M bench/GrMipMapBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.h View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 4 chunks +16 lines, -17 lines 0 comments Download
M dm/DM.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M dm/DMSrcSink.h View 3 chunks +5 lines, -5 lines 0 comments Download
M dm/DMSrcSink.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M example/HelloWorld.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M include/core/SkBitmap.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkImageInfo.h View 1 chunk +3 lines, -5 lines 0 comments Download
M include/core/SkPixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/SkGr.h View 1 chunk +2 lines, -3 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/views/SkWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 3 chunks +8 lines, -11 lines 0 comments Download
M src/core/SkBitmap.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGr.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/TestConfigParsing.cpp View 4 chunks +12 lines, -9 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.h View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/flags/SkCommonFlagsConfig.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M tools/picture_utils.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tools/skiaserve/Request.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M tools/viewer/Viewer.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M tools/viewer/sk_app/DisplayParams.h View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/viewer/sk_app/GLWindowContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/viewer/sk_app/WindowContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/viewer/sk_app/android/GLWindowContext_android.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/viewer/sk_app/android/RasterWindowContext_android.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Osman
Created Revert of Lots of progress switching to SkColorSpace rather than SkColorProfileType
4 years, 6 months ago (2016-06-16 18:41:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813002/1
4 years, 6 months ago (2016-06-16 18:41:24 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 18:41:47 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ab8241880d09eb1774b4993ca6df048a27b7020c

Powered by Google App Engine
This is Rietveld 408576698