Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2072533002: PPC64: increase stack-size for big-array-literal (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: increase stack-size for big-array-literal On PPC64 big-array-literal testcase is failing with stack overflow. Increasing the stack-size fixes the issue. R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/mjsunit/big-array-literal.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-15 19:30:47 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-16 05:14:26 UTC) #2
Michael Achenbach
lgtm
4 years, 6 months ago (2016-06-16 08:12:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072533002/1
4 years, 6 months ago (2016-06-16 13:50:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/3390) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-16 14:22:39 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072533002/1
4 years, 6 months ago (2016-06-16 15:15:15 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/3397) v8_win_nosnap_shared_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-16 15:33:51 UTC) #11
JaideepBajwa
4 years, 5 months ago (2016-06-27 18:06:13 UTC) #12
stack-size=1100 doesn't seem to agree with other platforms.
Disabling this testcase on ppc64 for now.
https://codereview.chromium.org/2098413002

Powered by Google App Engine
This is Rietveld 408576698