Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 2098413002: PPC64: disable big-array-literal testcase due to stack overflow (Closed)

Created:
4 years, 5 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: disable big-array-literal testcase due to stack overflow Testcase big-array-literal fails with stack overflow error on ppc64, increasing stack-size to 1100 resolves the issue, but causes other platforms to fail ( https://codereview.chromium.org/2072533002/ ). For now, disabling the testcase on ppc64. R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N NOTRY=true Committed: https://crrev.com/75219dad71ad1b783177d0ec641944d7c0f14626 Cr-Commit-Position: refs/heads/master@{#37324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
JaideepBajwa
PTAL
4 years, 5 months ago (2016-06-27 18:07:09 UTC) #1
michael_dawson
On 2016/06/27 18:07:09, JaideepBajwa wrote: > PTAL lgtm from PPC point of view
4 years, 5 months ago (2016-06-27 18:49:49 UTC) #2
Michael Achenbach
lgtm
4 years, 5 months ago (2016-06-28 09:29:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2098413002/1
4 years, 5 months ago (2016-06-28 12:20:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 12:23:05 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 12:24:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75219dad71ad1b783177d0ec641944d7c0f14626
Cr-Commit-Position: refs/heads/master@{#37324}

Powered by Google App Engine
This is Rietveld 408576698