Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add revision in ChromeTracingDelegate and AwTracingDelegate to keep version_info out of content Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index 57355af2b5fb25e83a2c12238619c9daf1de2928..1283f35a310dddda676dc6bbb341064d5d192d78 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -47,6 +47,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/layout.h"
#include "ui/base/resource/resource_bundle.h"
+#include "v8/include/v8.h"
#include "widevine_cdm_version.h" // In SHARED_INTERMEDIATE_DIR.
#if defined(OS_LINUX)
@@ -618,6 +619,10 @@ std::string ChromeContentClient::GetProduct() const {
return ::GetProduct();
}
+std::string ChromeContentClient::GetV8Version() const {
+ return v8::V8::GetVersion();
jam 2016/07/12 21:28:24 no need to create a new ContentClient method. cont
benjhayden 2016/07/15 01:22:08 content/DEPS had "-v8" in its include_rules, so I
+}
+
std::string ChromeContentClient::GetUserAgent() const {
return ::GetUserAgent();
}

Powered by Google App Engine
This is Rietveld 408576698