content/browser/tracing/tracing_controller_impl.cc - Issue 2072383002: Trace revision and v8 version for IterationInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add revision in ChromeTracingDelegate and AwTracingDelegate to keep version_info out of content Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tracing/tracing_controller_impl.cc

diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc

index 5756c737a5ac7328514f94e9b2113513bd400150..57258006304ca190c43d4bd83947e3e6342b3b67 100644

--- a/content/browser/tracing/tracing_controller_impl.cc

+++ b/content/browser/tracing/tracing_controller_impl.cc

@@ -114,6 +114,7 @@ std::unique_ptr<base::DictionaryValue> GenerateTracingMetadataDict() {

metadata_dict->SetString("network-type", GetNetworkTypeString());

metadata_dict->SetString("product-version", GetContentClient()->GetProduct());

+ metadata_dict->SetString("v8-version", GetContentClient()->GetV8Version());

metadata_dict->SetString("user-agent", GetContentClient()->GetUserAgent());

// OS