Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4143)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2072383002: Trace revision and v8 version for IterationInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: v8-version Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index f4414936e8e0e89a3495aec4073693e75ea35484..80b30bfe8333eaaa2dfa734c5a6b1bce2af33784 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -46,6 +46,7 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/layout.h"
#include "ui/base/resource/resource_bundle.h"
+#include "v8/include/v8.h"
#include "widevine_cdm_version.h" // In SHARED_INTERMEDIATE_DIR.
#if defined(OS_LINUX)
@@ -611,6 +612,14 @@ std::string ChromeContentClient::GetProduct() const {
return ::GetProduct();
}
+std::string ChromeContentClient::GetLastChange() const {
+ return version_info::GetLastChange();
Primiano Tucci (use gerrit) 2016/06/21 06:34:09 Why this plumbing here? This seems to defeat the p
benjhayden 2016/06/21 23:30:36 ** Presubmit ERRORS ** You added one or more #incl
Primiano Tucci (use gerrit) 2016/06/22 08:29:10 Yup, add it to content/browser/tracing/DEPS and th
+}
+
+std::string ChromeContentClient::GetV8Version() const {
+ return v8::V8::GetVersion();
+}
+
std::string ChromeContentClient::GetUserAgent() const {
return ::GetUserAgent();
}

Powered by Google App Engine
This is Rietveld 408576698