Trace revision and v8 version for IterationInfo

chrome/common/chrome_content_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_content_client.h"
 
 #include <stdint.h>
 
 #include <memory>
 #include <tuple>
@@ skipping 28 matching lines @@
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/common/user_agent.h"
 #include "extensions/common/constants.h"
 #include "gpu/config/gpu_info.h"
 #include "net/http/http_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/layout.h"
 #include "ui/base/resource/resource_bundle.h"
+#include "v8/include/v8.h"
 #include "widevine_cdm_version.h"  // In SHARED_INTERMEDIATE_DIR.
 
 #if defined(OS_LINUX)
 #include <fcntl.h>
 #include "chrome/common/component_flash_hint_file_linux.h"
 #endif  // defined(OS_LINUX)
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #endif
@@ skipping 545 matching lines @@
 
 bool ChromeContentClient::CanSendWhileSwappedOut(const IPC::Message* message) {
   return message->type() ==
          DataReductionProxyViewHostMsg_IsDataReductionProxy::ID;
 }
 
 std::string ChromeContentClient::GetProduct() const {
   return ::GetProduct();
 }
 
+std::string ChromeContentClient::GetLastChange() const {
+  return version_info::GetLastChange();

[Primiano Tucci (use gerrit), 2016/06/21 06:34:09]

Why this plumbing here? This seems to defeat the purpose of version_info.h being
a component.

[benjhayden, 2016/06/21 23:30:36]

** Presubmit ERRORS **
You added one or more #includes that violate checkdeps rules.
  content/browser/tracing/tracing_controller_impl.cc
      Illegal include: "components/version_info/version_info.h"
    Because of no rule applying.

Should I add a rule?

[Primiano Tucci (use gerrit), 2016/06/22 08:29:10]

Yup, add it to content/browser/tracing/DEPS and then you'll need a stamp from
one of the version_info owners (See components/version_info/OWNERS)

+}
+
+std::string ChromeContentClient::GetV8Version() const {
+  return v8::V8::GetVersion();
+}
+
 std::string ChromeContentClient::GetUserAgent() const {
   return ::GetUserAgent();
 }
 
 base::string16 ChromeContentClient::GetLocalizedString(int message_id) const {
   return l10n_util::GetStringUTF16(message_id);
 }
 
 base::StringPiece ChromeContentClient::GetDataResource(
     int resource_id,
@@ skipping 78 matching lines @@
 
 base::StringPiece ChromeContentClient::GetOriginTrialPublicKey() {
   return origin_trial_key_manager_.GetPublicKey();
 }
 
 #if defined(OS_ANDROID)
 media::MediaClientAndroid* ChromeContentClient::GetMediaClientAndroid() {
   return new ChromeMediaClientAndroid();
 }
 #endif  // OS_ANDROID