Source/core/rendering/FilterEffectRenderer.cpp - Issue 20723003: Fix pixel snapping issues when layers become composited

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/FilterEffectRenderer.cpp

Issue 20723003: Fix pixel snapping issues when layers become composited (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Adding another failing test expectation Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/FilterEffectRenderer.cpp

diff --git a/Source/core/rendering/FilterEffectRenderer.cpp b/Source/core/rendering/FilterEffectRenderer.cpp

index 5393f9c72a978e7c80371b3509456d0697e78606..a977bcd2dd8b7758abeb5a4c0fe8c638d1ac4f0e 100644

--- a/Source/core/rendering/FilterEffectRenderer.cpp

+++ b/Source/core/rendering/FilterEffectRenderer.cpp

@@ -355,7 +355,7 @@ bool FilterEffectRendererHelper::prepareFilterEffect(RenderLayer* renderLayer, c

m_repaintRect = dirtyRect;

FilterEffectRenderer* filter = renderLayer->filterRenderer();

- LayoutRect filterSourceRect = filter->computeSourceImageRectForDirtyRect(filterBoxRect, dirtyRect);

+ IntRect filterSourceRect = pixelSnappedIntRect(filter->computeSourceImageRectForDirtyRect(filterBoxRect, dirtyRect));

if (filterSourceRect.isEmpty()) {

// The dirty rect is not in view, just bail out.