Issue 20723002: Do not allow external strings in old pointer space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20723002: Do not allow external strings in old pointer space. (Closed)

Created:
7 years, 4 months ago by Yang

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -16 lines)			Patch
M	src/api.cc	View		3 chunks	+51 lines, -6 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-api.cc	View		2 chunks	+13 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Starzinger

LGTM. Can we also enable the test through the cctest.status file?

7 years, 4 months ago (2013-07-26 12:30:06 UTC) #2

Yang

7 years, 4 months ago (2013-07-26 12:32:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r15906 (presubmit successful).