src/mark-compact.cc - Issue 20723002: Do not allow external strings in old pointer space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mark-compact.cc

Issue 20723002: Do not allow external strings in old pointer space. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: updating cctest.status Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mark-compact.cc

diff --git a/src/mark-compact.cc b/src/mark-compact.cc

index 59492e16430432238cc04619af2f11d0be0f49b8..911e73b12a5224f861171beb3b7de56255ca2b37 100644

--- a/src/mark-compact.cc

+++ b/src/mark-compact.cc

@@ -2743,8 +2743,7 @@ void MarkCompactCollector::MigrateObject(Address dst,

if (dest == OLD_POINTER_SPACE) {

// TODO(hpayer): Replace this check with an assert.

HeapObject* heap_object = HeapObject::FromAddress(src);

- CHECK(heap_object->IsExternalString() ||

- heap_->TargetSpace(heap_object) == heap_->old_pointer_space());

+ CHECK(heap_->TargetSpace(heap_object) == heap_->old_pointer_space());

Address src_slot = src;

Address dst_slot = dst;

ASSERT(IsAligned(size, kPointerSize));

« no previous file with comments | « src/api.cc ('k') | test/cctest/cctest.status » ('j') | no next file with comments »