Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2072223002: Enforce use of the forEachInstanceField ordering for constructed constants. (Closed)

Created:
4 years, 6 months ago by Johnni Winther
Modified:
4 years, 6 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enforce use of the forEachInstanceField ordering for constructed constants. This ensures that constructed constants use the same field layout as the emitted classes. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/67b71d0cb793d5faaa2ee6f070741cc775a3f59a Reverted: https://github.com/dart-lang/sdk/commit/f817910fd03d49b42ec10346ae6f589d3dadae4e Committed: https://github.com/dart-lang/sdk/commit/c3085e31645fa333f58e6cb2847a37157b1b330b

Patch Set 1 #

Patch Set 2 : dartfmt #

Patch Set 3 : Include super fields + regression test #

Patch Set 4 : Remove tab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M pkg/compiler/lib/src/constants/values.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + tests/language/const_constructor_super2_test.dart View 1 2 3 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Johnni Winther
4 years, 6 months ago (2016-06-17 11:23:46 UTC) #3
Harry Terkelsen
lgtm
4 years, 6 months ago (2016-06-17 16:12:03 UTC) #4
Johnni Winther
Committed patchset #2 (id:20001) manually as 67b71d0cb793d5faaa2ee6f070741cc775a3f59a (presubmit successful).
4 years, 6 months ago (2016-06-20 08:36:29 UTC) #6
Johnni Winther
PTAL @ patch set 3+ (post commit)
4 years, 6 months ago (2016-06-20 10:46:36 UTC) #8
Johnni Winther
Committed patchset #4 (id:60001) manually as c3085e31645fa333f58e6cb2847a37157b1b330b (presubmit successful).
4 years, 6 months ago (2016-06-20 10:49:37 UTC) #10
Harry Terkelsen
4 years, 6 months ago (2016-06-20 16:11:00 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698