pkg/compiler/lib/src/js_backend/constant_system_javascript.dart - Issue 2072223002: Enforce use of the forEachInstanceField ordering for constructed constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

Issue 2072223002: Enforce use of the forEachInstanceField ordering for constructed constants. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Remove tab Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

diff --git a/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart b/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

index 410d1c86bbb1fd8c2ac83fe00c8a00a78eb4e98b..bfd156edcfa8463f12e5ba21e3985f28a604e858 100644

--- a/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

+++ b/pkg/compiler/lib/src/js_backend/constant_system_javascript.dart

@@ -357,7 +357,7 @@ class JavaScriptConstantSystem extends ConstantSystem {

symbolClass.forEachInstanceField(

(ClassElement enclosingClass, FieldElement field) {

fields[field] = argument;

- });

+ }, includeSuperAndInjectedMembers: true);

assert(fields.length == 1);

return new ConstructedConstantValue(type, fields);

}

« no previous file with comments | « pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart ('k') | pkg/compiler/lib/src/js_backend/namer.dart » ('j') | no next file with comments »