Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2072013004: Aria-owns should not work on roles that can't have children. (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 5 months ago
CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Aria-owns should not work on roles that can't have children. BUG=619641 Committed: https://crrev.com/022687c2fb7ab9c92fdf42d4a185a8a0107a4f1e Cr-Commit-Position: refs/heads/master@{#402515}

Patch Set 1 #

Patch Set 2 : Refactored test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dmazzoni
4 years, 6 months ago (2016-06-17 23:24:00 UTC) #2
dmazzoni
Friendly ping
4 years, 6 months ago (2016-06-23 15:39:11 UTC) #4
nektarios
+++ b/third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html +<!DOCTYPE HTML> I think that "html" should be lower case? +}, "Aria-owns doesn't ...
4 years, 6 months ago (2016-06-23 22:56:39 UTC) #5
nektarios
lgtm
4 years, 6 months ago (2016-06-23 22:57:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2072013004/20001
4 years, 5 months ago (2016-06-28 17:08:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 20:15:57 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 20:17:36 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/022687c2fb7ab9c92fdf42d4a185a8a0107a4f1e
Cr-Commit-Position: refs/heads/master@{#402515}

Powered by Google App Engine
This is Rietveld 408576698