third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp - Issue 2072013004: Aria-owns should not work on roles that can't have children.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2072013004: Aria-owns should not work on roles that can't have children. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactored test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

index c7bf66dbb301a94c2578a01f403415b9d08ae16d..996ebf0202825d68144dbd1f21802617fd7abe7b 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

@@ -2188,7 +2188,8 @@ void AXNodeObject::computeAriaOwnsChildren(HeapVector<Member<AXObject>>& ownedCh

return;

Vector<String> idVector;

- tokenVectorFromAttribute(idVector, aria_ownsAttr);

+ if (canHaveChildren())

+ tokenVectorFromAttribute(idVector, aria_ownsAttr);

axObjectCache().updateAriaOwns(this, idVector, ownedChildren);

}

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html ('k') | no next file » | no next file with comments »