Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2071783002: [d8] Make exception reporting more resilient. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[d8] Make exception reporting more resilient. This is a follow-up to a recent fix to make the exception reporting even more resilient. The original regression test flushed out more issues on different configurations. TBR=yangguo@chromium.org TEST=mjsunit/regress/regress-crbug-620253 BUG=chromium:620253 NOTREECHECKS=true Committed: https://chromium.googlesource.com/v8/v8/+/424d4f3bd2da161856d18289323957a50383d19d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/d8.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-16 11:08:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071783002/1
4 years, 6 months ago (2016-06-16 11:08:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/424d4f3bd2da161856d18289323957a50383d19d Cr-Commit-Position: refs/heads/master@{#37032}
4 years, 6 months ago (2016-06-16 11:19:12 UTC) #6
Michael Starzinger
Committed patchset #1 (id:1) manually as 424d4f3bd2da161856d18289323957a50383d19d (tree was closed).
4 years, 6 months ago (2016-06-16 11:19:14 UTC) #8
Yang
4 years, 6 months ago (2016-06-16 13:37:23 UTC) #9
Message was sent while issue was closed.
On 2016/06/16 11:19:14, Michael Starzinger wrote:
> Committed patchset #1 (id:1) manually as
> 424d4f3bd2da161856d18289323957a50383d19d (tree was closed).

lgtm.

Powered by Google App Engine
This is Rietveld 408576698