Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: src/d8.cc

Issue 2071783002: [d8] Make exception reporting more resilient. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index cc62aa8cb6acdcadda0a1dbc29ee2109d0b2b97b..c2f6a40ef3d75b24aa1b35a57f91436cca08c7d2 100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -928,12 +928,12 @@ void Shell::ReportException(Isolate* isolate, v8::TryCatch* try_catch) {
Maybe<int> maybeline = message->GetLineNumber(isolate->GetCurrentContext());
int linenum = maybeline.IsJust() ? maybeline.FromJust() : -1;
printf("%s:%i: %s\n", filename_string, linenum, exception_string);
- if (maybeline.IsJust()) {
+ Local<String> sourceline;
+ if (message->GetSourceLine(isolate->GetCurrentContext())
+ .ToLocal(&sourceline)) {
// Print line of source code.
- v8::String::Utf8Value sourceline(
- message->GetSourceLine(isolate->GetCurrentContext())
- .ToLocalChecked());
- const char* sourceline_string = ToCString(sourceline);
+ v8::String::Utf8Value sourcelinevalue(sourceline);
+ const char* sourceline_string = ToCString(sourcelinevalue);
printf("%s\n", sourceline_string);
// Print wavy underline (GetUnderline is deprecated).
int start =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698