Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2071713002: Add a PhysicalWebIgnoreOtherClients feature (Closed)

Created:
4 years, 6 months ago by cco3
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a PhysicalWebIgnoreOtherClients feature The Physical Web feature tests to see if other notification-based Physical Web clients exist on the device before surfacing notifications. This feature, when enabled, will bypass that check. BUG=616316 Committed: https://crrev.com/4159c8005f3f28b5d4381e6d37b8c33c3b1542ef Cr-Commit-Position: refs/heads/master@{#402329}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Make feature available without native library #

Total comments: 1

Patch Set 4 : Store setting in onChromeStart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 1 2 3 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
cco3
4 years, 6 months ago (2016-06-16 00:49:39 UTC) #2
cco3
ping
4 years, 6 months ago (2016-06-23 19:05:24 UTC) #3
mattreynolds
lgtm
4 years, 5 months ago (2016-06-24 17:52:23 UTC) #4
cco3
4 years, 5 months ago (2016-06-24 17:59:02 UTC) #6
cco3
4 years, 5 months ago (2016-06-24 17:59:16 UTC) #8
nyquist
lgtm
4 years, 5 months ago (2016-06-24 19:13:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2071713002/1
4 years, 5 months ago (2016-06-27 16:36:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/27399) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-06-27 16:39:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2071713002/20001
4 years, 5 months ago (2016-06-27 17:20:08 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/94341)
4 years, 5 months ago (2016-06-27 18:16:32 UTC) #18
rkaplow
lgtm
4 years, 5 months ago (2016-06-27 18:45:42 UTC) #19
cco3
Matt, could you take a second look at the java files?
4 years, 5 months ago (2016-06-27 19:03:41 UTC) #20
cco3
Matt, could you take a second look at the java files?
4 years, 5 months ago (2016-06-27 19:03:41 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2071713002/60001
4 years, 5 months ago (2016-06-27 21:48:10 UTC) #24
mattreynolds
https://codereview.chromium.org/2071713002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/2071713002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode66 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:66: boolean ignoreOtherClients = ChromeFeatureList.isEnabled(IGNORE_OTHER_CLIENTS_FEATURE_NAME); Let's move this to onChromeStart ...
4 years, 5 months ago (2016-06-27 21:48:59 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-27 23:26:26 UTC) #26
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 23:29:26 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4159c8005f3f28b5d4381e6d37b8c33c3b1542ef
Cr-Commit-Position: refs/heads/master@{#402329}

Powered by Google App Engine
This is Rietveld 408576698