chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java - Issue 2071713002: Add a PhysicalWebIgnoreOtherClients feature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

Issue 2071713002: Add a PhysicalWebIgnoreOtherClients feature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Store setting in onChromeStart Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java ('k') | chrome/browser/android/chrome_feature_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

index 374f7e042755661bcc37e59dd88b662988db3729..34b72c72567de72a80c1e28602a232fc13e4f3e8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

@@ -467,9 +467,10 @@ class UrlManager {

private void showNotification() {

// We should only show notifications if there's no other notification-based client.

- if (PhysicalWebEnvironment

- .getInstance((ChromeApplication) mContext.getApplicationContext())

- .hasNotificationBasedClient()) {

+ if (!PhysicalWeb.shouldIgnoreOtherClients()

+ && PhysicalWebEnvironment

+ .getInstance((ChromeApplication) mContext.getApplicationContext())

+ .hasNotificationBasedClient()) {

return;

}