Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/gn/variables.cc

Issue 2071573003: GN: Use implicit dependency for binary input deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 3c717d82ed60346525b47141581c1cef0e613b35..7b2c4a088f7c6b1947e0edff16f022f7055b936b 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -1048,13 +1048,11 @@ const char kInputs_Help[] =
" files in a target are compiled. So if you depend on generated headers,\n"
" you do not typically need to list them in the inputs section.\n"
"\n"
- " Inputs for binary targets will be treated as order-only dependencies,\n"
- " meaning that they will be forced up to date before compiling or\n"
- " any files in the target, but changes in the inputs will not\n"
- " necessarily force the target to compile. This is because it is\n"
- " expected that the compiler will report the precise list of input\n"
- " dependencies required to recompile each file once the initial build\n"
- " is done.\n"
+ " Inputs for binary targets will be treated as implicit dependencies,\n"
+ " meaning that changes in any of the inputs will force all sources in\n"
+ " the target to be recompiled. If an input only applies to a subset of\n"
+ " source files, you may want to split those into a separate target to\n"
+ " avoid unnecessary recompiles.\n"
"\n"
"Example\n"
"\n"
« no previous file with comments | « tools/gn/ninja_target_writer_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698