Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: tools/gn/ninja_target_writer_unittest.cc

Issue 2071573003: GN: Use implicit dependency for binary input deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review changes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/variables.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer_unittest.cc
diff --git a/tools/gn/ninja_target_writer_unittest.cc b/tools/gn/ninja_target_writer_unittest.cc
index ccb9c7a3cebb81b4d76c6550bc918552ca1a8348..55bbde05db5aaa9bf054076138897b0cbe81d8f1 100644
--- a/tools/gn/ninja_target_writer_unittest.cc
+++ b/tools/gn/ninja_target_writer_unittest.cc
@@ -85,12 +85,9 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
OutputFile dep =
writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
- // Since there is more than one dependency, a stamp file will be returned
- // and the rule for the stamp file will be written to the stream.
- EXPECT_EQ("obj/foo/target.inputdeps.stamp", dep.value());
- EXPECT_EQ("build obj/foo/target.inputdeps.stamp: stamp "
- "../../foo/input.txt obj/foo/base.stamp\n",
- stream.str());
+ // Since there is only one dependency, a stamp file will be returned
+ // directly without writing any additional rules.
+ EXPECT_EQ("obj/foo/base.stamp", dep.value());
}
// Input deps for action which should depend on the base since its a hard dep
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698