Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 207153003: Assert that FreeListElement is never wrapped in a handle. (Closed)

Created:
6 years, 9 months ago by koda
Modified:
6 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Assert that FreeListElement is never wrapped in a handle. Previously, this just crashed with a segfault (since its vtable entry is 0). R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=34257

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 9 months ago (2014-03-21 00:25:21 UTC) #1
siva
lgtm
6 years, 9 months ago (2014-03-21 16:22:48 UTC) #2
koda
6 years, 9 months ago (2014-03-21 16:31:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698