DescriptionRevert of Default components to static libraries in GN build (patchset #3 id:40001 of https://codereview.chromium.org/2060983002/ )
Reason for revert:
Build broken:
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder
See https://bugs.chromium.org/p/chromium/issues/detail?id=619949
For recommendation to revert.
Original issue's description:
> Default components to static libraries in GN build
>
> Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow.
>
> Reland of https://codereview.chromium.org/2043873004/ and https://codereview.chromium.org/2063483002 but disabled for official Windows builds.
>
> In support of the official condition, is_official_build moved to BUILDCONFIG. Since this is really a different level of debug/release, this may actually make more sense. The documentation around this was enhanced a lot, official now automatically turns off debug, and it will assert if you override both to produce an official debug build.
>
> BUG=617837
>
> Committed: https://crrev.com/022f8f346d72007cf75469299f894ad4edfda5a8
> Cr-Commit-Position: refs/heads/master@{#399633}
TBR=dpranke@chromium.org,brettw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=617837
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|