Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2071493002: Revert of Default components to static libraries in GN build (Closed)

Created:
4 years, 6 months ago by picksi1
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Default components to static libraries in GN build (patchset #3 id:40001 of https://codereview.chromium.org/2060983002/ ) Reason for revert: Build broken: https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder See https://bugs.chromium.org/p/chromium/issues/detail?id=619949 For recommendation to revert. Original issue's description: > Default components to static libraries in GN build > > Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow. > > Reland of https://codereview.chromium.org/2043873004/ and https://codereview.chromium.org/2063483002 but disabled for official Windows builds. > > In support of the official condition, is_official_build moved to BUILDCONFIG. Since this is really a different level of debug/release, this may actually make more sense. The documentation around this was enhanced a lot, official now automatically turns off debug, and it will assert if you override both to produce an official debug build. > > BUG=617837 > > Committed: https://crrev.com/022f8f346d72007cf75469299f894ad4edfda5a8 > Cr-Commit-Position: refs/heads/master@{#399633} TBR=dpranke@chromium.org,brettw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=617837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -79 lines) Patch
M base/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 3 chunks +16 lines, -42 lines 0 comments Download
M build/config/chrome_build.gni View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
picksi1
Created Revert of Default components to static libraries in GN build
4 years, 6 months ago (2016-06-15 14:54:09 UTC) #1
petrcermak
lgtm
4 years, 6 months ago (2016-06-15 14:55:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071493002/1
4 years, 6 months ago (2016-06-15 14:56:06 UTC) #5
brettw
On 2016/06/15 14:56:06, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-06-15 15:12:40 UTC) #7
Dirk Pranke
4 years, 6 months ago (2016-06-15 15:26:04 UTC) #8
On 2016/06/15 15:12:40, brettw wrote:
> On 2016/06/15 14:56:06, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/2071493002/1
> 
> Please don't revert, I can fix this easily another way. Reverting this will
> cause a Windows try builder time exceed its SLA.

I agree, let's fix the builder instead.

Powered by Google App Engine
This is Rietveld 408576698