Simplify landmines code a bit now that all branches of all platforms are on ninja

Simplify landmines code a bit now that all branches of all platforms are on ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Committed: https://crrev.com/08e9878eadb7ce7477f5947190d4b4c29acf2f56
Cr-Original-Commit-Position: refs/heads/master@{#408739}
Cr-Commit-Position: refs/heads/master@{#408818}

[Nico, 2016-06-15 12:39:09]

thakis@chromium.org changed reviewers:
+ iannucci@chromium.org

[Nico, 2016-06-15 12:39:10]

https://codereview.chromium.org/2071463002/diff/1/build/landmine_utils.py
File build/landmine_utils.py (left):

https://codereview.chromium.org/2071463002/diff/1/build/landmine_utils.py#old...
build/landmine_utils.py:70: return 'ib' # use (win and !goma and headless) as
approximation of ib
we haven't used ib in a long time; i removed support for it from compile.py a
while ago and nothing exploded

[Nico, 2016-06-21 18:15:32]

iannucci: ping

[iannucci, 2016-07-19 01:19:14]

lgtm sorry I missed this :/

[Nico, 2016-07-29 18:37:10]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-07-29 18:38:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:03:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 21:04:43]

Description was changed from

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none
==========

to

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

[commit-bot: I haz the power, 2016-07-29 21:04:44]

Patchset 2 (id:??) landed as
https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}

[brettw, 2016-07-29 22:20:26]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2198583002/ by brettw@chromium.org.

The reason for reverting is: I just synced on Windows and this is giving me:

________ running 'D:\depot_tools\python276_bin\python.exe src/build/landmines.py
' in 'D:\src\src1'
Traceback (most recent call last):
  File "D:\src\src1\src\build\get_landmines.py", line 16, in <module>
    builder = landmine_utils.builder
AttributeError: 'module' object has no attribute 'builder'
Clobbering due to:
--- old_landmines       Tue Aug 12 16:34:51 2014
+++ new_landmines       Fri Jul 29 15:16:56 2016
@@ -1,17 +0,0 @@
-Compile on cc_unittests fails due to symbols removed in r185063.
-Improper dependency for create_nmf.py broke in r240802, fixed in r240860.
-Switch to VS2015 Update 2
-Need to clobber everything due to an IDL change in r154579 (blink)
-Need to clobber everything due to gen file moves in r175513 (Blink)
-Clobber to get rid of obselete test plugin after r248358
-Clobber to rebuild GN files for V8
-Clobber to get rid of stale generated mojom.h files
-Need to clobber everything due to build_nexe change in nacl r13424
-[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...
-blink_resources.grd changed: crbug.com/400860
-ninja dependency cycle: crbug.com/408192
-Clobber to fix missing NaCl gyp dependencies (crbug.com/427427).
-Another clobber for missing NaCl gyp deps (crbug.com/427427).
-Clobber to fix GN not picking up increased ID range (crbug.com/444902)
-Remove NaCl toolchains from the output dir (crbug.com/456902)
-Clobber to delete stale generated files (crbug.com/510086).

[Nico, 2016-07-29 22:55:28]

Description was changed from

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

to

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

[Nico, 2016-07-29 22:56:07]

The CQ bit was checked by thakis@chromium.org

[Nico, 2016-07-29 22:56:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2071463002/#ps40001
(title: "fix for reland")

[commit-bot: I haz the power, 2016-07-29 22:56:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 00:35:37]

Description was changed from

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

to

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

[commit-bot: I haz the power, 2016-07-30 00:35:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-30 00:37:03]

Description was changed from

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Cr-Commit-Position: refs/heads/master@{#408739}
==========

to

==========
Simplify landmines code a bit now that all branches of all platforms are on
ninja

BUG=none

Committed: https://crrev.com/7491d14275670fad399837445b6c1e76ff498a50
Committed: https://crrev.com/08e9878eadb7ce7477f5947190d4b4c29acf2f56
Cr-Original-Commit-Position: refs/heads/master@{#408739}
Cr-Commit-Position: refs/heads/master@{#408818}
==========

[commit-bot: I haz the power, 2016-07-30 00:37:04]

Patchset 3 (id:??) landed as
https://crrev.com/08e9878eadb7ce7477f5947190d4b4c29acf2f56
Cr-Commit-Position: refs/heads/master@{#408818}