Simplify landmines code a bit now that all branches of all platforms are on ninja

build/get_landmines.py

 #!/usr/bin/env python
 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """
 This file emits the list of reasons why a particular build needs to be clobbered
 (or a list of 'landmines').
 """
 
 import sys
 
 import landmine_utils
 
 
-builder = landmine_utils.builder
 distributor = landmine_utils.distributor
 gyp_defines = landmine_utils.gyp_defines
 gyp_msvs_version = landmine_utils.gyp_msvs_version
 platform = landmine_utils.platform
 
 
 def print_landmines():
   """
   ALL LANDMINES ARE EMITTED FROM HERE.
   """
   # DO NOT add landmines as part of a regular CL. Landmines are a last-effort
   # bandaid fix if a CL that got landed has a build dependency bug and all bots
   # need to be cleaned up. If you're writing a new CL that causes build
   # dependency problems, fix the dependency problems instead of adding a
   # landmine.
 
-  if (distributor() == 'goma' and platform() == 'win32' and
-      builder() == 'ninja'):
+  if distributor() == 'goma' and platform() == 'win32':
     print 'Need to clobber winja goma due to backend cwd cache fix.'
   if platform() == 'android':
     print 'Clobber: to handle new way of suppressing findbugs failures.'
     print 'Clobber to fix gyp not rename package name (crbug.com/457038)'
-  if platform() == 'win' and builder() == 'ninja':
+  if platform() == 'win':
     print 'Compile on cc_unittests fails due to symbols removed in r185063.'
-  if platform() == 'linux' and builder() == 'ninja':
+  if platform() == 'linux':
     print 'Builders switching from make to ninja will clobber on this.'
   if platform() == 'mac':
     print 'Switching from bundle to unbundled dylib (issue 14743002).'
   if platform() in ('win', 'mac'):
     print ('Improper dependency for create_nmf.py broke in r240802, '
            'fixed in r240860.')
-  if (platform() == 'win' and builder() == 'ninja' and
+  if (platform() == 'win' and
       gyp_msvs_version() == '2012' and
       gyp_defines().get('target_arch') == 'x64' and
       gyp_defines().get('dcheck_always_on') == '1'):
     print "Switched win x64 trybots from VS2010 to VS2012."
-  if (platform() == 'win' and builder() == 'ninja' and
+  if (platform() == 'win' and
       gyp_msvs_version().startswith('2013')):
     print "Switch to VS2013"
   if (platform() == 'win' and gyp_msvs_version().startswith('2015')):
     print 'Switch to VS2015 Update 2'
   print 'Need to clobber everything due to an IDL change in r154579 (blink)'
   print 'Need to clobber everything due to gen file moves in r175513 (Blink)'
   if (platform() != 'ios'):
     print 'Clobber to get rid of obselete test plugin after r248358'
     print 'Clobber to rebuild GN files for V8'
   print 'Clobber to get rid of stale generated mojom.h files'
@@ skipping 17 matching lines @@
     print 'Clobber to remove libsystem.dylib. See crbug.com/620075'
 
 
 def main():
   print_landmines()
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())