Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 207143003: Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometime… (Closed)

Created:
6 years, 9 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometimes it's 0; BUG=331927 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebPluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 9 months ago (2014-03-20 23:09:20 UTC) #1
tkent
lgtm
6 years, 9 months ago (2014-03-24 02:16:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/207143003/1
6 years, 9 months ago (2014-03-24 02:16:26 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 02:18:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-24 02:18:24 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 9 months ago (2014-03-24 02:25:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/207143003/1
6 years, 9 months ago (2014-03-24 02:25:39 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 06:49:07 UTC) #8
Message was sent while issue was closed.
Change committed as 169825

Powered by Google App Engine
This is Rietveld 408576698