Source/web/WebPluginDocument.cpp - Issue 207143003: Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometime…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebPluginDocument.cpp

Issue 207143003: Check toWebPluginContainerImpl() result before dereferencing, even with isPluginDocument() sometime… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebPluginDocument.cpp

diff --git a/Source/web/WebPluginDocument.cpp b/Source/web/WebPluginDocument.cpp

index 7bf547dd405535a2e6e25f7c76ae52a3df07a800..c0ee65be4c4b79cb7dcb863125f1d2049147b73e 100644

--- a/Source/web/WebPluginDocument.cpp

+++ b/Source/web/WebPluginDocument.cpp

@@ -49,7 +49,7 @@ WebPlugin* WebPluginDocument::plugin()

return 0;

PluginDocument* doc = unwrap<PluginDocument>();

WebPluginContainerImpl* container = toWebPluginContainerImpl(doc->pluginWidget());

- return container->plugin();

+ return container ? container->plugin() : 0;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »