Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 207143002: Make FrameTree::uniqueName() more unique. (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Make FrameTree::uniqueName() more unique. Currently, it only guarantees no two siblings have the same unique name. This patch tries much harder to guarantee that no two frames in the same page have the same unique name. BUG=352651 TEST=http/tests/history/frameset-repeated-name.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169764

Patch Set 1 #

Patch Set 2 : Use name() instead of uniqueName() for find() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
A LayoutTests/http/tests/history/frameset-repeated-name.html View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/history/frameset-repeated-name-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/history/resources/frameset-dest.html View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameTree.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/FrameTree.cpp View 1 6 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Nate Chapin
6 years, 9 months ago (2014-03-20 23:04:47 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-21 00:25:18 UTC) #2
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-21 16:17:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/207143002/1
6 years, 9 months ago (2014-03-21 16:17:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 16:53:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-21 16:53:39 UTC) #6
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-21 17:21:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/207143002/20001
6 years, 9 months ago (2014-03-21 17:21:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 17:53:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 17:54:00 UTC) #10
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-21 17:54:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/207143002/20001
6 years, 9 months ago (2014-03-21 17:54:41 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 18:16:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-21 18:16:29 UTC) #14
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-21 18:18:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/207143002/20001
6 years, 9 months ago (2014-03-21 18:18:47 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 19:27:46 UTC) #17
Message was sent while issue was closed.
Change committed as 169764

Powered by Google App Engine
This is Rietveld 408576698