Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: Source/core/page/FrameTree.h

Issue 207143002: Make FrameTree::uniqueName() more unique. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use name() instead of uniqueName() for find() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. 2 * Copyright (C) 2006 Apple Computer, Inc.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 unsigned childCount() const; 54 unsigned childCount() const;
55 55
56 LocalFrame* scopedChild(unsigned index) const; 56 LocalFrame* scopedChild(unsigned index) const;
57 LocalFrame* scopedChild(const AtomicString& name) const; 57 LocalFrame* scopedChild(const AtomicString& name) const;
58 unsigned scopedChildCount() const; 58 unsigned scopedChildCount() const;
59 void invalidateScopedChildCount(); 59 void invalidateScopedChildCount();
60 60
61 private: 61 private:
62 LocalFrame* deepLastChild() const; 62 LocalFrame* deepLastChild() const;
63 AtomicString uniqueChildName(const AtomicString& requestedName) const; 63 AtomicString uniqueChildName(const AtomicString& requestedName) const;
64 bool uniqueNameExists(const AtomicString& name) const;
64 unsigned scopedChildCount(TreeScope*) const; 65 unsigned scopedChildCount(TreeScope*) const;
65 66
66 LocalFrame* m_thisFrame; 67 LocalFrame* m_thisFrame;
67 68
68 AtomicString m_name; // The actual frame name (may be empty). 69 AtomicString m_name; // The actual frame name (may be empty).
69 AtomicString m_uniqueName; 70 AtomicString m_uniqueName;
70 71
71 mutable unsigned m_scopedChildCount; 72 mutable unsigned m_scopedChildCount;
72 }; 73 };
73 74
74 } // namespace WebCore 75 } // namespace WebCore
75 76
76 #ifndef NDEBUG 77 #ifndef NDEBUG
77 // Outside the WebCore namespace for ease of invocation from gdb. 78 // Outside the WebCore namespace for ease of invocation from gdb.
78 void showFrameTree(const WebCore::LocalFrame*); 79 void showFrameTree(const WebCore::LocalFrame*);
79 #endif 80 #endif
80 81
81 #endif // FrameTree_h 82 #endif // FrameTree_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698