Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2071073002: Removes waiter member from BackgroundOfflinerTask to make it easier to reason about thread safety (Closed)

Created:
4 years, 6 months ago by dougarnett
Modified:
4 years, 6 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes waiter member from BackgroundOfflinerTask to make it easier to reason about thread safety (eg, don't have to worry about two concurrent calls). BUG=612325 Committed: https://crrev.com/3b44616bcf69700ca97c8ca219ac3414a8cc1254 Cr-Commit-Position: refs/heads/master@{#400298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dougarnett
4 years, 6 months ago (2016-06-16 22:04:35 UTC) #2
Pete Williamson
lgtm
4 years, 6 months ago (2016-06-16 22:06:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071073002/1
4 years, 6 months ago (2016-06-16 22:54:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 23:39:03 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 23:41:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b44616bcf69700ca97c8ca219ac3414a8cc1254
Cr-Commit-Position: refs/heads/master@{#400298}

Powered by Google App Engine
This is Rietveld 408576698