Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

Issue 2071073002: Removes waiter member from BackgroundOfflinerTask to make it easier to reason about thread safety (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
index 0029d3da9f47f39e5ee54c072d328e0f1733735b..3ce2f580e2891480db8cf62d0a9eda0387e80cd5 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java
@@ -10,6 +10,7 @@ import android.os.Bundle;
import org.chromium.base.BaseChromiumApplication;
import org.chromium.base.test.util.Feature;
+import org.chromium.chrome.browser.ChromeBackgroundServiceWaiter;
import org.chromium.testing.local.LocalRobolectricTestRunner;
import org.junit.Before;
import org.junit.Test;
@@ -40,10 +41,13 @@ public class BackgroundOfflinerTaskTest {
public void testIncomingTask() {
BackgroundOfflinerTask task =
new BackgroundOfflinerTask(mStubBackgroundSchedulerProcessor);
- task.processBackgroundRequests(mTaskExtras);
+ ChromeBackgroundServiceWaiter waiter = new ChromeBackgroundServiceWaiter(1);
+ task.processBackgroundRequests(mTaskExtras, waiter);
// Check with ShadowBackgroundBackgroundSchedulerProcessor that startProcessing got called.
assertTrue(mStubBackgroundSchedulerProcessor.getStartProcessingCalled());
+
+ // TODO(dougarnett): Call processor callback and verify waiter signaled.
}
@Test
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698