List all crashes in chrome://crashes, including those not uploaded

components/crash/content/app/crashpad.cc

Index: components/crash/content/app/crashpad.cc
diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc
index 1c0c49936dddb46e5645116276923c81215fb11b..0c40b9ff97de76f5d4155a5f634d7c7b0442e3f3 100644
--- a/components/crash/content/app/crashpad.cc
+++ b/components/crash/content/app/crashpad.cc
@@ -285,14 +285,12 @@ void GetUploadedReports(std::vector<UploadedReport>* uploaded_reports) {
 
   for (const crashpad::CrashReportDatabase::Report& completed_report :
        completed_reports) {
-    if (completed_report.uploaded) {
-      UploadedReport uploaded_report;
-      uploaded_report.local_id = completed_report.uuid.ToString();
-      uploaded_report.remote_id = completed_report.id;
-      uploaded_report.creation_time = completed_report.creation_time;
+    UploadedReport uploaded_report;

[Mark Mentovai, 2016/06/16 22:02:04]

UploadedReport is a misnomer now.

Given the above comment, maybe it should grow a field that distinguishes between
pending, completed-uploaded, and completed-not-uploaded. Then you could rely on
that elsewhere instead of further overloading the remote_id field.

[scottmg, 2016/06/16 22:28:08]

Yeah :(, was being a bit lazy. components/upload_list is misnamed too, so it's
going to be a big whack of a CL. I'll see how it goes.

+    uploaded_report.local_id = completed_report.uuid.ToString();
+    uploaded_report.remote_id = completed_report.id;
+    uploaded_report.creation_time = completed_report.creation_time;
 
-      uploaded_reports->push_back(uploaded_report);
-    }
+    uploaded_reports->push_back(uploaded_report);
   }
 
   std::sort(uploaded_reports->begin(), uploaded_reports->end(),