List all crashes in chrome://crashes, including those not uploaded

components/crash/content/app/crashpad.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <stddef.h>
 #include <string.h>
 
 #if BUILDFLAG(ENABLE_KASKO)
@@ skipping 260 matching lines @@
 
 void GetUploadedReports(std::vector<UploadedReport>* uploaded_reports) {
   uploaded_reports->clear();
 
   if (!g_database) {
     return;
   }
 
   std::vector<crashpad::CrashReportDatabase::Report> completed_reports;
   crashpad::CrashReportDatabase::OperationStatus status =
       g_database->GetCompletedReports(&completed_reports);

[Mark Mentovai, 2016/06/16 22:02:04]

Since we want to show not-uploaded reports, should we call GetPendingReports()
and add those to the list too? Perhaps bubble something up to the UI saying that
an upload attempt will still be made for those?

[scottmg, 2016/06/16 22:28:08]

Yeah, that seems reasonable, but gets more complicated when the state would be
expected to change. We'd sort of want to have the page auto refresh as the 
state changes or something? Maybe it's OK if the user has to manually refresh
for that case.

[Mark Mentovai, 2016/06/16 23:16:05]

scottmg wrote:
At some point, it might be nice to notify on state changes, but we’re probably
not at that point yet. It starts to become more interesting once we have a
working “upload now” button, so that the progress shows up on about:crashes in
real time.

   if (status != crashpad::CrashReportDatabase::kNoError) {
     return;
   }
 
   for (const crashpad::CrashReportDatabase::Report& completed_report :
        completed_reports) {
-    if (completed_report.uploaded) {
-      UploadedReport uploaded_report;
-      uploaded_report.local_id = completed_report.uuid.ToString();
-      uploaded_report.remote_id = completed_report.id;
-      uploaded_report.creation_time = completed_report.creation_time;
+    UploadedReport uploaded_report;

[Mark Mentovai, 2016/06/16 22:02:04]

UploadedReport is a misnomer now.

Given the above comment, maybe it should grow a field that distinguishes between
pending, completed-uploaded, and completed-not-uploaded. Then you could rely on
that elsewhere instead of further overloading the remote_id field.

[scottmg, 2016/06/16 22:28:08]

Yeah :(, was being a bit lazy. components/upload_list is misnamed too, so it's
going to be a big whack of a CL. I'll see how it goes.

+    uploaded_report.local_id = completed_report.uuid.ToString();
+    uploaded_report.remote_id = completed_report.id;
+    uploaded_report.creation_time = completed_report.creation_time;
 
-      uploaded_reports->push_back(uploaded_report);
-    }
+    uploaded_reports->push_back(uploaded_report);
   }
 
   std::sort(uploaded_reports->begin(), uploaded_reports->end(),
             [](const UploadedReport& a, const UploadedReport& b) {
               return a.creation_time > b.creation_time;
             });
 }
 
 #if BUILDFLAG(ENABLE_KASKO)
 
@@ skipping 99 matching lines @@
                                    base::UTF16ToUTF8(value));
 }
 
 void __declspec(dllexport) __cdecl ClearCrashKeyValueImpl(const wchar_t* key) {
   crash_reporter::ClearCrashKey(base::UTF16ToUTF8(key));
 }
 
 }  // extern "C"
 
 #endif  // OS_WIN