Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/BUILD.gn

Issue 2070903002: Add an XPC service to handle alert notifications on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_builder_add_response
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 268328b6710a39f18f7404924e3ba3402d5cf181..ade20fc84273420150aa323521e8b1f33351722b 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -472,6 +472,20 @@ if (is_win) {
}
}
+ bundle_data("chrome_framework_services") {
+ sources = [
+ "$root_out_dir/AlertNotificationService.xpc",
+ ]
+
+ outputs = [
+ "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
+ ]
+ }
+
tweak_info_plist("chrome_app_plist") {
info_plist = "app/app-Info.plist"
_keystone_arg = "0"
@@ -992,6 +1006,7 @@ if (is_win) {
":chrome_framework_helpers",
":chrome_framework_plugins",
":chrome_framework_resources",
+ ":chrome_framework_services",
Robert Sesek 2016/09/29 14:23:04 Adding this deps should be guarded by the buildfla
Miguel Garcia 2016/10/03 16:07:50 What problem do you see in adding this right now?
Robert Sesek 2016/10/04 16:04:25 This will start bundling the XPC service even in t
":packed_resources",
":widevine_cdm_library",
"//build/config/sanitizers:deps",
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/notifications/BUILD.gn » ('j') | chrome/browser/ui/cocoa/notifications/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698