Add an XPC service to handle alert notifications on mac

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
 import("//build/config/sanitizers/sanitizers.gni")
@@ skipping 454 matching lines @@
     }
 
     if (is_chrome_branded && is_official_build) {
       deps += [
         ":chrome_dsym_archive",
         ":chrome_dump_syms",
       ]
     }
   }
 
+  bundle_data("chrome_framework_services") {
+    sources = [
+      "$root_out_dir/AlertNotificationService.xpc",
+    ]
+
+    outputs = [
+      "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
+    ]
+
+    public_deps = [
+      "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
+    ]
+  }
+
   tweak_info_plist("chrome_app_plist") {
     info_plist = "app/app-Info.plist"
     _keystone_arg = "0"
     if (enable_mac_keystone) {
       _keystone_arg = "1"
     }
     args = [
       "--breakpad=0",
       "--keystone=$_keystone_arg",
       "--scm=1",
@@ skipping 500 matching lines @@
     ]
 
     public_deps = [
       ":chrome_dll",
     ]
 
     deps = [
       ":chrome_framework_helpers",
       ":chrome_framework_plugins",
       ":chrome_framework_resources",
+      ":chrome_framework_services",

[Robert Sesek, 2016/09/29 14:23:04]

Adding this deps should be guarded by the buildflag. (The bundle_data target
should probably be guarded as well).

[Miguel Garcia, 2016/10/03 16:07:50]

What problem do you see in adding this right now? If I guard this by the flag I
lose compile coverage which is a pity.

[Robert Sesek, 2016/10/04 16:04:25]

This will start bundling the XPC service even in the case where it's not
explicitly enabled via the compile-time flag.

You could add the
//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service to
src/BUILD.gn I think.

       ":packed_resources",
       ":widevine_cdm_library",
       "//build/config/sanitizers:deps",
       "//chrome/app/nibs:chrome_xibs",
     ]
 
     if (is_chrome_branded) {
       deps += [ ":default_apps" ]
     }
 
@@ skipping 519 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }