Bug fixes for hot reload

Bug fixes for hot reload

- [x] Report the reload error synchronously from the _reloadSources RPC.
- [x] Add sticky reload error to an isolate so we can report the error.
- [x] Remove redundant 'OnStackReload'.
- [x] Fix a bug where a class could have a field added but we wouldn't reject it.
- [x] Add unit test for above bug fix.
- [x] Enable reload via the service protocol with a live stack.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/51ace86544800e3ab1dc415e6545d45bf1424dd0

[Cutch, 2016-06-16 16:11:38]

Description was changed from

==========
asdjhfjksadf

BUG=
==========

to

==========
Bug fixes for hot reload

- [x] Report the reload error synchronously from the _reloadSources RPC.
- [x] Add sticky reload error to an isolate so we can report the error.
- [x] Remove redundant 'OnStackReload'.
- [x] Fix a bug where a class could have a field added but we wouldn't reject
it.
- [x] Add unit test for above bug fix.
- [x] Enable reload via the service protocol with a live stack.
==========

[Cutch, 2016-06-16 16:11:38]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[Cutch, 2016-06-16 17:11:57]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com
- rmacnak@google.com

[Cutch, 2016-06-16 17:12:09]

Switching reviewers because Ryan's OOO

[Florian Schneider, 2016-06-16 17:30:00]

lgtm

https://codereview.chromium.org/2070873002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2070873002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:2505: return true;
This function never seems to return false. Is the result used at all? If not,
you should make it return void.

[Cutch, 2016-06-16 18:02:26]

https://codereview.chromium.org/2070873002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/2070873002/diff/20001/runtime/vm/service.cc#n...
runtime/vm/service.cc:2505: return true;
On 2016/06/16 17:30:00, Florian Schneider wrote:
> This function never seems to return false. Is the result used at all? If not,
> you should make it return void.

A service protocol handler can return false if they have not directly handled
the request (possibly sending it to another isolate for processing).

[Cutch, 2016-06-16 18:02:39]

Description was changed from

==========
Bug fixes for hot reload

- [x] Report the reload error synchronously from the _reloadSources RPC.
- [x] Add sticky reload error to an isolate so we can report the error.
- [x] Remove redundant 'OnStackReload'.
- [x] Fix a bug where a class could have a field added but we wouldn't reject
it.
- [x] Add unit test for above bug fix.
- [x] Enable reload via the service protocol with a live stack.
==========

to

==========
Bug fixes for hot reload

- [x] Report the reload error synchronously from the _reloadSources RPC.
- [x] Add sticky reload error to an isolate so we can report the error.
- [x] Remove redundant 'OnStackReload'.
- [x] Fix a bug where a class could have a field added but we wouldn't reject
it.
- [x] Add unit test for above bug fix.
- [x] Enable reload via the service protocol with a live stack.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/51ace86544800e3ab1dc415e6545d45bf1424dd0
==========

[Cutch, 2016-06-16 18:02:41]

Committed patchset #2 (id:20001) manually as
51ace86544800e3ab1dc415e6545d45bf1424dd0 (presubmit successful).