Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 2070873002: Bug fixes for hot reload (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix an error message Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/code_patcher.h" 9 #include "vm/code_patcher.h"
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 OS::PrintErr("*** Computing stacktrace (%s)\n", 1290 OS::PrintErr("*** Computing stacktrace (%s)\n",
1291 function.ToFullyQualifiedCString()); 1291 function.ToFullyQualifiedCString());
1292 do_stacktrace = true; 1292 do_stacktrace = true;
1293 } 1293 }
1294 } 1294 }
1295 if (do_deopt) { 1295 if (do_deopt) {
1296 // TODO(turnidge): Consider using DeoptimizeAt instead. 1296 // TODO(turnidge): Consider using DeoptimizeAt instead.
1297 DeoptimizeFunctionsOnStack(); 1297 DeoptimizeFunctionsOnStack();
1298 } 1298 }
1299 if (do_reload) { 1299 if (do_reload) {
1300 NOT_IN_PRODUCT(isolate->OnStackReload();) 1300 NOT_IN_PRODUCT(isolate->ReloadSources();)
1301 } 1301 }
1302 if (FLAG_support_debugger && do_stacktrace) { 1302 if (FLAG_support_debugger && do_stacktrace) {
1303 String& var_name = String::Handle(); 1303 String& var_name = String::Handle();
1304 Instance& var_value = Instance::Handle(); 1304 Instance& var_value = Instance::Handle();
1305 // Collecting the stack trace and accessing local variables 1305 // Collecting the stack trace and accessing local variables
1306 // of frames may trigger parsing of functions to compute 1306 // of frames may trigger parsing of functions to compute
1307 // variable descriptors of functions. Parsing may trigger 1307 // variable descriptors of functions. Parsing may trigger
1308 // code execution, e.g. to compute compile-time constants. Thus, 1308 // code execution, e.g. to compute compile-time constants. Thus,
1309 // disable FLAG_stacktrace_every during trace collection to prevent 1309 // disable FLAG_stacktrace_every during trace collection to prevent
1310 // recursive stack trace collection. 1310 // recursive stack trace collection.
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1879 const intptr_t elm_size = old_data.ElementSizeInBytes(); 1879 const intptr_t elm_size = old_data.ElementSizeInBytes();
1880 const TypedData& new_data = 1880 const TypedData& new_data =
1881 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld)); 1881 TypedData::Handle(TypedData::New(cid, new_size, Heap::kOld));
1882 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size); 1882 TypedData::Copy(new_data, 0, old_data, 0, old_size * elm_size);
1883 typed_data_cell.SetAt(0, new_data); 1883 typed_data_cell.SetAt(0, new_data);
1884 arguments.SetReturn(new_data); 1884 arguments.SetReturn(new_data);
1885 } 1885 }
1886 1886
1887 1887
1888 } // namespace dart 1888 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698