Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 2070533002: win: Add an explicit intrin.h include to work around a clang-cl bug. (Closed)

Created:
2 years, 11 months ago by Nico
Modified:
2 years, 11 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

win: Add an explicit intrin.h include to work around a clang-cl bug. It's admittedly pretty lame to put this workaround in, but last I checked this was the only file needing this workaround, and force-including intrin.h in _every_ translation unit isn't great either. So let's add this workaround for now so we can remove that force-inclusion. BUG=chromium:592745 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/8d49f6b628879a41bac93660f27bf694e6bc7143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/shared/platform/win/nacl_secure_random.c View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
2 years, 11 months ago (2016-06-15 11:56:25 UTC) #2
Roland McGrath
lgtm
2 years, 11 months ago (2016-06-15 21:51:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070533002/1
2 years, 11 months ago (2016-06-16 01:43:35 UTC) #5
commit-bot: I haz the power
2 years, 11 months ago (2016-06-16 01:45:33 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/8d49f6b62...

Powered by Google App Engine
This is Rietveld 408576698