Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2070493002: Expose fnmatch in presubmit's input_api. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -13 lines) Patch
M presubmit_support.py View 2 chunks +2 lines, -1 line 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +53 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
dcheng
To support https://codereview.chromium.org/2070483002/ (since maruel already had a TODO to add this to input_api anyway)
4 years, 6 months ago (2016-06-15 10:31:51 UTC) #3
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-15 15:06:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070493002/1
4 years, 6 months ago (2016-06-15 15:37:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/606)
4 years, 6 months ago (2016-06-15 15:45:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070493002/1
4 years, 6 months ago (2016-06-16 08:24:58 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 08:27:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/091b7db64c188e...

Powered by Google App Engine
This is Rietveld 408576698